Don't stop on breakpoints when running the swift Object Description function #10693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting "IgnoreBreakpointsInExpressions", so it was stopping on breakpoints. That's not how the ObjC object description is run, and is not what people expect here. I added the setting to the options in the Swift case, and added a test that we don't stop on breakpoints in the Object Description expression.
|
@swift-ci test |
|
@swift-ci test windows |
kastiglione
approved these changes
May 19, 2025
|
@jimingham Can add a skip on windows to the new test? |
| def test_value_types(self): | ||
| """Test 'po' on a variety of value types with and without custom descriptions.""" | ||
| self.build() | ||
| (_,_,_,_) = lldbutil.run_to_source_breakpoint(self, "Break here to run tests", lldb.SBFileSpec("main.swift")) |
There was a problem hiding this comment.
Suggested change
| (_,_,_,_) = lldbutil.run_to_source_breakpoint(self, "Break here to run tests", lldb.SBFileSpec("main.swift")) | |
| lldbutil.run_to_source_breakpoint(self, "Break here to run tests", lldb.SBFileSpec("main.swift")) |
|
Apparently inlined swift tests are skipped in a different way than normal API tests, and when switching from one to the other I didn't notice the @swifttest was missing. We don't currently run the swift tests on Windows (we don't actually know how to build the test binary there), and so the missing decorator meant we tried the new test on Windows which didn't go well. |
|
@swift-ci please test |
|
@swift-ci test linux |
jimingham
added a commit
that referenced
this pull request
May 21, 2025
…unction (#10693) * The Swift `object description` expression was being run without setting "IgnoreBreakpointsInExpressions", so it was stopping on breakpoints. That's not how the ObjC object description is run, and is not what people expect here. I added the setting to the options in the Swift case, and added a test that we don't stop on breakpoints in the Object Description expression. * Mark the tests as @swifttest and fix the test name. (cherry picked from commit d8693d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift
object descriptionexpression was being run without setting "IgnoreBreakpointsInExpressions", so it was stopping on breakpoints. That's not how the ObjC object description is run, and is not what people expect here.I added the setting to the options in the Swift case, and added a test that we don't stop on breakpoints in the Object Description expression.
rdar://150698964